[ 
https://issues.apache.org/jira/browse/ARTEMIS-4652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17826873#comment-17826873
 ] 

ASF subversion and git services commented on ARTEMIS-4652:
----------------------------------------------------------

Commit 269be13c5a291c3944d8c379413398a6913985e4 in activemq-artemis's branch 
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=269be13c5a ]

ARTEMIS-4652 rollback of XAResource impl shouldn't return XA_RETRY

This fix was based on static analysis of the code and inspection of the
XA specification. There is no test associated with it due to the
difficult nature in reproducing the failure. This code has been
essentially the same for a decade and only now have there been any
reports of it actually sending back the wrong XA code.


> Rollback of XAResource implementation should never return XA_RETRY
> ------------------------------------------------------------------
>
>                 Key: ARTEMIS-4652
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4652
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> According to [the XA 
> spec|https://pubs.opengroup.org/onlinepubs/009680699/toc.pdf] {{XA_RETRY}} is 
> not a valid response from {{xa_rollback}}. We should return {{XAER_RMFAIL}} 
> instead.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to