[
https://issues.apache.org/jira/browse/ARTEMIS-4689?focusedWorklogId=909951&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909951
]
ASF GitHub Bot logged work on ARTEMIS-4689:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/24 17:39
Start Date: 14/Mar/24 17:39
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4855:
URL: https://github.com/apache/activemq-artemis/pull/4855#discussion_r1525274543
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##########
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
Review Comment:
just use hidden=true, no need to deprecate things in the CLI.
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataImporter.java:
##########
@@ -90,10 +91,12 @@ public final class XmlDataImporter extends ActionAbstract {
private ClientSession session;
private ClientProducer producer;
- @Option(names = "--host", description = "The host used to import the data.
Default: localhost.")
- public String host = "localhost";
+ @Deprecated(forRemoval = true)
+ @Option(names = "--host", description = "The host used to import the data.
Default: null. Deprecated! Use 'url' instead.")
+ public String host = null;
- @Option(names = "--port", description = "The port used to import the data.
Default: 61616.")
+ @Deprecated(forRemoval = true)
+ @Option(names = "--port", description = "The port used to import the data.
Default: 61616. Deprecated! Use 'url' instead.")
Review Comment:
just use hidden
Issue Time Tracking
-------------------
Worklog Id: (was: 909951)
Time Spent: 20m (was: 10m)
> Import command should accept URL
> --------------------------------
>
> Key: ARTEMIS-4689
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4689
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently the import command only takes host & port with regard to its
> connection to the broker. It should take a URL instead so that the connection
> can be configured appropriately for more use-cases (e.g. using TLS).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
