[
https://issues.apache.org/jira/browse/ARTEMIS-4709?focusedWorklogId=912987&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-912987
]
ASF GitHub Bot logged work on ARTEMIS-4709:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Apr/24 09:23
Start Date: 04/Apr/24 09:23
Worklog Time Spent: 10m
Work Description: gtully commented on PR #4871:
URL:
https://github.com/apache/activemq-artemis/pull/4871#issuecomment-2036652885
> Is there a particular reason this needs to be a plugin vs. just a normal
bit of functionality in the core server? Plugins are nice for some things, but
they're kind of clunky to configure. This seems like something that would fit
well on an `acceptor` URL.
I am thinking that the broker is all about keeping connections alive or
whacking them when consumers are slow etc, but this plugin is a very blunt and
simple approach, that is ideal for security or some special operator sla, but
not a core concern.
It is cross cutting (generally applicable), but not typically necessary so
leaving it totally optional makes sense to me.
If it turns out that this plugin becomes part of lots of deployments, and
possibly we need to improve from a performance point of view, we can consider
pulling it into the core.
The plugin api makes the logic simple to implement, understand and maintain
or extend, but also makes it totally optional. I think those are all positives.
On the config, I make this plugin a java bean with a name, and through
properties it is fairly intuitive. I think the chunkiness of plugin config is a
different problem, but not a reason to not use plugins!
Issue Time Tracking
-------------------
Worklog Id: (was: 912987)
Time Spent: 1h 20m (was: 1h 10m)
> Add a plugin to provide periodic expiry of connections on a per acceptor basis
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-4709
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4709
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Affects Versions: 2.33.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Fix For: 2.34.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> When credential rotation needs to be enforced, active connections need to be
> terminated on some timeline to ensure credentials are reevaluated. There are
> management apis that can be used but these require some intervention.
> In addition to enforce some SLA around duration of connections, having an
> easy way to limit connections to a given maximum period can be helpful.
> A plugin that will be applied on an per acceptor basis, that can be used to
> disconnect connections that have lived for some period can provide a nice
> building block for these use cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
