[ 
https://issues.apache.org/jira/browse/ARTEMIS-1219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1219.
-------------------------------------
    Resolution: Invalid

This test was removed from the code-base awhile back.

> [extra-tests] LargeMessageOverReplicationTest#testReceiveLargeMessage is 
> failing
> --------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1219
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1219
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.2.0
>            Reporter: Jiri Daněk
>            Priority: Minor
>              Labels: tests
>
> LargeMessageOverReplicationTest#testReceiveLargeMessage is failing with the 
> following log messages
> {noformat}
> java.lang.AssertionError: Expected a failure here
>       at org.junit.Assert.fail(Assert.java:88)
>       at 
> org.apache.activemq.artemis.tests.extras.byteman.LargeMessageOverReplicationTest.testReceiveLargeMessage(LargeMessageOverReplicationTest.java:193)
>       at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>       at java.lang.reflect.Method.invoke(Method.java:498)
>       at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
>       at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>       at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
>       at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
>       at 
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$9.evaluate(BMUnitRunner.java:342)
>       at 
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$6.evaluate(BMUnitRunner.java:241)
>       at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
>       at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>       at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>       at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>       at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>       at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>       at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
>       at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>       at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:271)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:70)
>       at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:50)
>       at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
>       at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
>       at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
>       at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
>       at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
>       at 
> org.jboss.byteman.contrib.bmunit.BMUnitRunner$1.evaluate(BMUnitRunner.java:75)
>       at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
>       at org.junit.runner.JUnitCore.run(JUnitCore.java:160)
>       at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:68)
>       at 
> com.intellij.rt.execution.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:51)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:242)
>       at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:70)
> {noformat}
> Using git-bisect, the following commit was identified as the breaking one
> {noformat}
> 279383a7985dd9b92ab89584bf7eda7029343be8 is the first bad commit
> commit 279383a7985dd9b92ab89584bf7eda7029343be8
> Author: Martyn Taylor <[email protected]>
> Date:   Tue Nov 29 14:11:27 2016 +0000
>     ARTEMIS-780 Update Shared Queue API to use Address model
> :040000 040000 72c31f8774c447852a9a7525930dc04b470c5c7e 
> fb0433b0550c3c7f3a145c6ee2143c5541b4dbbd M      artemis-core-client
> :040000 040000 b8c45a3ff81a5645567013bc1510d8a241313776 
> de5768e915abe80b9fe456f53c839473f67d57ac M      artemis-jms-client
> :040000 040000 d886c0f23d2ee6421d31b76729889bb9299641ba 
> b1a3353b35bdb64258c8726d9707e2274c9d41d7 M      artemis-server
> :040000 040000 68b9370a789920a42f2013c1ffcf423bae7f7121 
> 9b39d4694cf6f3c9f955968d3713fb26cf8207e6 M      tests
> {noformat}
> CC [~martyntaylor]
> Looking at the fix (which I am reasonably confident about), couldn't be there 
> some specific error when client tries to treat a multicast-routed address as 
> a jms queue (instead of a jms topic)? I am talking about the following code 
> in {{org.apache.activemq.artemis.core.postoffice.impl.LocalQueueBinding}}
> {noformat}
>    @Override
>    public void route(final Message message, final RoutingContext context) 
> throws Exception {
>       if (isMatchRoutingType(context)) {
>          queue.route(message, context);
>       }
>    }
> {noformat}
> What was happening in this issue was that {{isMatchRoutingType(context)}} 
> evaluated to false and {{queue.route(message, context)}} was never called.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to