[ 
https://issues.apache.org/jira/browse/ARTEMIS-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram resolved ARTEMIS-1671.
-------------------------------------
    Resolution: Not A Problem

False positive.

> FindBugs: Null pointer dereferences  (FORWARD_NULL) in 
> AbstractJournalStorageManager.java
> -----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1671
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1671
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Jiri Daněk
>            Priority: Major
>
> {noformat}
> ________________________________________________________________________________________________________
> *** CID 1465016:  Null pointer dereferences  (FORWARD_NULL)
> /activemq-artemis/artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/AbstractJournalStorageManager.java:
>  1775 in 
> org.apache.activemq.artemis.core.persistence.impl.journal.AbstractJournalStorageManager.loadPreparedTransactions(org.apache.activemq.artemis.core.postoffice.PostOffice,
>  org.apache.activemq.artemis.core.paging.PagingManager, 
> org.apache.activemq.artemis.core.transaction.ResourceManager, java.util.Map, 
> java.util.List, java.util.Map, java.util.Map, java.util.Set, 
> org.apache.activemq.artemis.core.server.impl.JournalLoader)()
> 1769                       encoding.position.setRecordID(record.id);
> 1770
> 1771                       PageSubscription sub = 
> locateSubscription(encoding.queueID, pageSubscriptions, queueInfos, 
> pagingManager);
> 1772
> 1773                       if (sub != null) {
> 1774                          sub.reloadPreparedACK(tx, encoding.position);
> >>>     CID 1465016:  Null pointer dereferences  (FORWARD_NULL)
> >>>     Passing "null" to "PagedReferenceImpl", which dereferences it.
> 1775                          referencesToAck.add(new 
> PagedReferenceImpl(encoding.position, null, sub));
> 1776                       } else {
> 1777                          
> ActiveMQServerLogger.LOGGER.journalCannotFindQueueReloadingACK(encoding.queueID);
> 1778                       }
> 1779                       break;
> 1780                    }
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to