[
https://issues.apache.org/jira/browse/AMQ-9447?focusedWorklogId=914139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914139
]
ASF GitHub Bot logged work on AMQ-9447:
---------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/24 11:37
Start Date: 11/Apr/24 11:37
Worklog Time Spent: 10m
Work Description: mattrpav commented on code in PR #1194:
URL: https://github.com/apache/activemq/pull/1194#discussion_r1560887925
##########
activemq-broker/src/main/java/org/apache/activemq/broker/jmx/HealthView.java:
##########
@@ -167,6 +169,25 @@ public List<HealthStatus> healthList() throws Exception {
}
}
+ /**
+ * Check The Transport Connector limits
+ */
+
+ if (brokerService != null &&
!brokerService.getTransportConnectors().isEmpty()) {
+ for(TransportConnector tc:
brokerService.getTransportConnectors()) {
+ if(tc.getServer() instanceof TcpTransportServer) {
+ int connectionUsage = (int)
(((TcpTransportServer)tc.getServer()).getCurrentTransportCount().get() * 100 )
/ ((TcpTransportServer)tc.getServer()).getMaximumConnections();
+
if(((TcpTransportServer)tc.getServer()).getCurrentTransportCount().get() >=
((TcpTransportServer)tc.getServer()).getMaximumConnections()) {
+ String message = "Exceeded the maximum
number of allowed client connections: " +
((TcpTransportServer)tc.getServer()).getMaximumConnections();
Review Comment:
This check can’t happen since the connector will close a connection when it
reaches the limit. An exceeded count isn’t possible.
I think this branch of logic should just be removed and simply go with the
limit check
Issue Time Tracking
-------------------
Worklog Id: (was: 914139)
Time Spent: 1h 40m (was: 1.5h)
> ActiveMQ Jolokia health service returns "good" even when persistence or
> transports are failing
> ----------------------------------------------------------------------------------------------
>
> Key: AMQ-9447
> URL: https://issues.apache.org/jira/browse/AMQ-9447
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: Broker, JMX
> Affects Versions: 5.18.3
> Reporter: Ephemeris Lappis
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 6.2.0, 5.18.5
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The Jolokia health service only considers the BrokerService status, it
> doesn't check all layers (like persistent store or transports).
> The CurrentStatus should not be "Good" if some underlying service is failing.
> For example, with a JDBC persistence adapter, if the DB is not reachable, the
> broker should not be considered as OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
