[
https://issues.apache.org/jira/browse/ARTEMIS-4723?focusedWorklogId=914221&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914221
]
ASF GitHub Bot logged work on ARTEMIS-4723:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Apr/24 15:53
Start Date: 11/Apr/24 15:53
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4880:
URL: https://github.com/apache/activemq-artemis/pull/4880#discussion_r1561260496
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/actors/ProcessorBase.java:
##########
@@ -117,13 +112,6 @@ public int shutdownNow(Consumer<? super T> onPendingItem,
int timeout, TimeUnit
requestedShutdown = true;
yielded = false;
- if (!inHandler()) {
- // We don't have an option where we could do an immediate timeout
- // I just need to make one roundtrip to make sure there's no pending
tasks on the loop
- // for that I ellected one second
- flush(timeout, unit);
Review Comment:
This was for tests and it was still causing issues anyway...
so, time to go !!! more issues than benefits
Issue Time Tracking
-------------------
Worklog Id: (was: 914221)
Time Spent: 20m (was: 10m)
> org.apache.activemq.artemis.utils.actors.Handler$Counter left on the
> ThreadLocal
> --------------------------------------------------------------------------------
>
> Key: ARTEMIS-4723
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4723
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> org.apache.activemq.artemis.utils.actors.Handler$Counter is left on the
> ThreadLocal.
> This is used to verify if the execution is InHander.
> The object could be removed after done. So it's not a growing leak (meaning
> it will keep growing), but it's an unnecessary allocation that can be avoided.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
