[ 
https://issues.apache.org/jira/browse/ARTEMIS-1921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17837645#comment-17837645
 ] 

Robbie Gemmell commented on ARTEMIS-1921:
-----------------------------------------

Not sure we should be expecting a response after 6 years, but it seems possible 
the code was a minimal attempt to show 'it isnt available on Core at all' 
rather than simply 'it is available at this point on the others', perhaps the 
use case is something else later where it is available on the others. Or maybe 
some behaviour changed in those 6 years and it used to be available; I actually 
think it might have in the AMQP case, I seem to recall it doing something odd 
like calling the auth methods when the first session opened like Core. Not sure 
it does that anymore.

The ClientID wont be available at the point Qpid JMS actually goes through the 
SASL process, since it hasnt been sent yet, regardless how the client is 
configured, auth happens 'before connection' rather than during. If the broker 
fails the SASL negotiation, the client wont even get as far as starting a bare 
AMQP connection which is where the ClientId is carried as the container-id.

I presume it is failing auth in this case and throwing. If it doenst fail auth, 
the test/application code will still throw with Qpid JMS since it is _both_ 
setting the ClientID up front 'administratively', and then also trying to set 
it after Connection creation, whereas you can only do one or the other. The 
second will throw an ISE if it gets that far.

> Setting client ID on core JMS should be reflected in broker RemotingConnection
> ------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1921
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1921
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.6.1
>            Reporter: Johan Stenberg
>            Priority: Major
>         Attachments: Artemis1921_CoreJmsClient_SetClientId_Test.java
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> As opposite to Qpid JMS Client over AMPQ1.0 or FuseSource StompJMS client 
> over STOMP, a clientID set on the JMS ConnectionFactory or the Connection in 
> the Artemis JMS Client is not available on the broker via 
> RemotingConnection#getClientID().



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to