[
https://issues.apache.org/jira/browse/ARTEMIS-4725?focusedWorklogId=914935&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-914935
]
ASF GitHub Bot logged work on ARTEMIS-4725:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Apr/24 16:06
Start Date: 16/Apr/24 16:06
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #4888:
URL: https://github.com/apache/activemq-artemis/pull/4888#discussion_r1567621714
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java:
##########
@@ -825,8 +826,14 @@ protected ReadableBuffer createDeliveryCopy(int
deliveryCount, DeliveryAnnotatio
}
writeDeliveryAnnotationsForSendBuffer(result, deliveryAnnotations);
- // skip existing delivery annotations of the original message
- duplicate.position(encodedHeaderSize + encodedDeliveryAnnotationsSize);
+
Review Comment:
I'm not convinced you need to change this after having adjusted the
encodedHeraderSize value to account for it not being at the start of the
buffer. I must say that it feels a bit odd to be allowing wrongly encoded AMQP
message format zero messages through in the first place, we probably should
have been catching that and rejecting the messages really.
Issue Time Tracking
-------------------
Worklog Id: (was: 914935)
Time Spent: 1h 40m (was: 1.5h)
> Mirror may send wrong headers
> -----------------------------
>
> Key: ARTEMIS-4725
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4725
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> This is not specifically an issue in Mirroring or Broker Connection, but it
> manifested as part of the broker connection codebase.
> When a delivery for the first time after a reload happens, the delivery
> annotation may be written before the header, breaking the specification.
> Later on delivery the message, createDelieryCopy could get confused with the
> positions:
> https://github.com/apache/activemq-artemis/blob/50fae08b09a76e200ef107d06cc867231f644ccd/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPMessage.java#L829
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
