[ 
https://issues.apache.org/jira/browse/ARTEMIS-1634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Clebert Suconic closed ARTEMIS-1634.
------------------------------------

> Coverity: Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) in 
> QueueControlImpl.java
> -----------------------------------------------------------------------------------------
>
>                 Key: ARTEMIS-1634
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1634
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>          Components: Broker
>    Affects Versions: 2.5.0
>            Reporter: Jiri Daněk
>            Assignee: Justin Bertram
>            Priority: Major
>             Fix For: 2.34.0
>
>
> {noformat}
>    @Override
>    public CompositeData[] browse(int page, int pageSize) throws Exception {
>       String filter = null;
>       checkStarted();
>       clearIO();
>       try {
>          long index = 0;
> CID 1464349 (#1 of 2): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN) 
> [select issue]
>          long start = (page - 1) * pageSize;
> CID 1464349 (#2 of 2): Unintentional integer overflow 
> (OVERFLOW_BEFORE_WIDEN)overflow_before_widen: Potentially
>   overflowing expression page * pageSize with type int (32 bits, signed) is 
> evaluated using 32-bit arithmetic, and then used
>   in a context that expects an expression of type long (64 bits, signed). To 
> avoid overflow, cast either page or pageSize to
>   type long rather than casting the result of the potential overflow.
>          long end = Math.min((long)(page * pageSize), 
> queue.getMessageCount());
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to