[ 
https://issues.apache.org/jira/browse/ARTEMIS-4814?focusedWorklogId=923431&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-923431
 ]

ASF GitHub Bot logged work on ARTEMIS-4814:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/24 05:35
            Start Date: 14/Jun/24 05:35
    Worklog Time Spent: 10m 
      Work Description: joshb1050 commented on code in PR #4972:
URL: https://github.com/apache/activemq-artemis/pull/4972#discussion_r1639286235


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/postoffice/impl/SimpleAddressManager.java:
##########
@@ -100,6 +102,8 @@ public boolean addBinding(final Binding binding) throws 
Exception {
       if (nameMap.putIfAbsent(binding.getUniqueName(), bindingAddressPair) != 
null) {
          throw ActiveMQMessageBundle.BUNDLE.bindingAlreadyExists(binding);
       }
+      directBindingMap.computeIfAbsent(binding.getAddress(), (unused) -> new 
ArrayList<>())
+              .add(binding);

Review Comment:
   Now using an `ArrayList` given that the modifications are happening in a 
(synchronized) `compute` block.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 923431)
    Time Spent: 2h 40m  (was: 2.5h)

> Remove linear iteration to get direct bindings
> ----------------------------------------------
>
>                 Key: ARTEMIS-4814
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4814
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>          Components: Broker
>            Reporter: Josh Byster
>            Priority: Minor
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> Currently, with 500K+ queues, the cleanup step of {{TempQueueCleanerUpper}} 
> requires invoking {{WildcardAddressManager#getDirectBindings}}, which is O(k) 
> in the number of queues.
> From method profiling, this can consume up to 95% of our CPU time when 
> needing to clean up many of these. 
> It would be nice to make this more efficient, which shouldn't be difficult 
> given the iteration just does a simple equality check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to