[
https://issues.apache.org/jira/browse/ARTEMIS-4662?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justin Bertram updated ARTEMIS-4662:
------------------------------------
Description:
PR:
[https://github.com/apache/activemq-artemis/pull/4835/commits/b893c6c4d35b42ee2364144c8850bd104caf6fe7]
In the detectAndReportRenewSlowness() method, the logger.error() and
logger.warn() methods are called 3 times.
In two of the three calls, the method arguments correspond to parameters that
are tested in the if() conditional construct.
Also, the arguments of the logger.error() and logger.warn() methods are
identical in lines 139 and 141, respectively, which may indicate that they were
copied incorrectly.
was:
PR:
[https://github.com/apache/activemq-artemis/pull/4835/commits/b893c6c4d35b42ee2364144c8850bd104caf6fe7]
In the detectAndReportRenewSlowness() method, the logger.error() and
logger.warn() methods are called 3 times.
In two of the three calls, the method arguments correspond to parameters that
are tested in the if() conditional construct.
Also, the arguments of the logger.error() and logger.warn() methods are
identical in lines 139 and 141, respectively, which may indicate that they were
copied incorrectly.
Found by Linux Verification Center (portal.linuxtesting.ru) with SVACE.
Author A. Slepykh.
> BAD_COPY_PASTE in ActiveMQScheduledLeaseLock.java
> -------------------------------------------------
>
> Key: ARTEMIS-4662
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4662
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Andrey Slepykh
> Assignee: Justin Bertram
> Priority: Minor
> Labels: easy-fix, pull-request-available
>
> PR:
> [https://github.com/apache/activemq-artemis/pull/4835/commits/b893c6c4d35b42ee2364144c8850bd104caf6fe7]
> In the detectAndReportRenewSlowness() method, the logger.error() and
> logger.warn() methods are called 3 times.
> In two of the three calls, the method arguments correspond to parameters that
> are tested in the if() conditional construct.
> Also, the arguments of the logger.error() and logger.warn() methods are
> identical in lines 139 and 141, respectively, which may indicate that they
> were copied incorrectly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
