[
https://issues.apache.org/jira/browse/ARTEMIS-4831?focusedWorklogId=924000&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-924000
]
ASF GitHub Bot logged work on ARTEMIS-4831:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jun/24 14:27
Start Date: 21/Jun/24 14:27
Worklog Time Spent: 10m
Work Description: gemmellr opened a new pull request, #4989:
URL: https://github.com/apache/activemq-artemis/pull/4989
Always use surefure default behaviour by default: fail module build when a
test fails.
Anyone wanting to ignore failures so as to run all modules, can use the
standard surefire prop to request that, e.g:
mvn test -Dmaven.test.failure.ignore
Issue Time Tracking
-------------------
Worklog Id: (was: 924000)
Remaining Estimate: 0h
Time Spent: 10m
> consistently use surefire default behaviour around test failure
> ---------------------------------------------------------------
>
> Key: ARTEMIS-4831
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4831
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: Tests
> Affects Versions: 2.35.0
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Major
> Fix For: 2.36.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently, the artemis build explicitly configures maven/surefire to ignore
> test failures most of the time, both out of the box, and when running most of
> the test profiles. The artemis build _only_ configures maven/surefire to its
> usual standard behaviour (to fail the whole build at the module which first
> failed a test) for the 'fast-tests' profile used in the PR test runs.
> This is horrible out of the box behaviour because if people dont know this,
> as many wont and almost noone would assume, then they can entirely miss the
> fact that there were test failures because they are buried by subsequent test
> output, and the end command result is then success with a nice banner from
> Maven indicating BUILD SUCCESS. Most folks not using something like Jenkins
> with the JUnit test results processing, or running the aggregate surefire
> report after testing and looking, is likely to miss failures they have
> introduced. I have seen this happen in a few PRs just recently.
> Surefire already has a dedicated property to give this behaviour, easily
> configurable via the pom or CLI: {_}maven.test.failure.ignore{_}. The default
> artemis build behaviour should adopt the default surefire behaviour everyone
> is already used to and almost certainly expects it already uses. Anyone who
> does specifically wish to have the ignoring behaviour to run all modules can
> configure maven/surefire when running it, e.g:
> {code:java}
> mvn test -Dmaven.test.failure.ignore{code}
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact