[
https://issues.apache.org/jira/browse/AMQ-9484?focusedWorklogId=925942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-925942
]
ASF GitHub Bot logged work on AMQ-9484:
---------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jul/24 14:54
Start Date: 15/Jul/24 14:54
Worklog Time Spent: 10m
Work Description: cshannon commented on code in PR #1258:
URL: https://github.com/apache/activemq/pull/1258#discussion_r1677966382
##########
activemq-broker/src/main/java/org/apache/activemq/store/memory/MemoryMessageStore.java:
##########
@@ -130,6 +130,32 @@ public void recoverNextMessages(int maxReturned,
MessageRecoveryListener listene
}
}
+ @Override
+ public void recoverNextMessages(int offset, int maxReturned,
MessageRecoveryListener listener) throws Exception {
+ synchronized (messageTable) {
+ boolean pastLackBatch = lastBatchId == null;
Review Comment:
looks like a small typo here
Issue Time Tracking
-------------------
Worklog Id: (was: 925942)
Time Spent: 1h 20m (was: 1h 10m)
> Support exporting kahadb messages from a queue with an offset
> -------------------------------------------------------------
>
> Key: AMQ-9484
> URL: https://issues.apache.org/jira/browse/AMQ-9484
> Project: ActiveMQ Classic
> Issue Type: New Feature
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Minor
> Fix For: 6.2.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Support exporting and pulling messages from a MessageStore with an offset, to
> prevent loading _every_ message into memory (and subsequent required gc).
> For example, if a user wants to export the last message from a queue with
> 1,000 messages, they can scan over the index skipping most messages vs
> loading all messages into memory to get to the last message.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact