[
https://issues.apache.org/jira/browse/ARTEMIS-4925?focusedWorklogId=926222&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926222
]
ASF GitHub Bot logged work on ARTEMIS-4925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/24 20:03
Start Date: 16/Jul/24 20:03
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5092:
URL: https://github.com/apache/activemq-artemis/pull/5092#discussion_r1680003308
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/replication/ReplicationEndpoint.java:
##########
@@ -831,8 +830,8 @@ private void handlePageEvent(final
ReplicationPageEventMessage packet) throws Ex
private void handlePageWrite(final ReplicationPageWriteMessage packet)
throws Exception {
PagedMessage pgdMessage = packet.getPagedMessage();
pgdMessage.initMessage(storageManager);
- Message msg = pgdMessage.getMessage();
- Page page = getPage(msg.getAddressSimpleString(),
packet.getPageNumber());
+ SimpleString address = packet.getAddress();
+ Page page = getPage(address, packet.getPageNumber());
Review Comment:
nitpick...could be just:
```java
Page page = getPage(packet.getAddress(), packet.getPageNumber());
```
Issue Time Tracking
-------------------
Worklog Id: (was: 926222)
Time Spent: 20m (was: 10m)
> Mirroring and Replication do not work in combination
> ----------------------------------------------------
>
> Key: ARTEMIS-4925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4925
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.35.0
> Reporter: Clebert Suconic
> Priority: Major
> Fix For: 2.36.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Mirror and replication will not work in combination.
> When I first developed mirroring I thought mirroring would be a replacement
> on replication and people would not really mix both. However users reported
> me about a setup where they use replication in a local setup, and mirror for
> DR and that caused issues.
> Basically when paging, the write of the page will fail under replication,
> because the message on the SNF for mirror will have a different address then
> where it's stored, and that will cause issues in the process such as file
> leaks and wrong writes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
