[
https://issues.apache.org/jira/browse/ARTEMIS-4939?focusedWorklogId=926722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-926722
]
ASF GitHub Bot logged work on ARTEMIS-4939:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Jul/24 18:24
Start Date: 19/Jul/24 18:24
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5103:
URL: https://github.com/apache/activemq-artemis/pull/5103#discussion_r1684798818
##########
artemis-dto/src/main/java/org/apache/activemq/artemis/dto/WebServerDTO.java:
##########
@@ -107,6 +107,9 @@ public class WebServerDTO extends ComponentDTO {
@XmlAttribute
public Integer scanPeriod;
+ @XmlAttribute
+ public Integer requestHeaderSize;
Review Comment:
My only comment here is that this attribute name, while matching the
HttpConfiguration type's value isn't exactly self documenting as it doesn't
really convey it is a limit unlike the other options in this DTO. I'd have
gone with something like requestHeaderSizeLimit or maxRequestHeaderSize just so
it conveys the intent more clearly.
Issue Time Tracking
-------------------
Worklog Id: (was: 926722)
Time Spent: 20m (was: 10m)
> Allow configuring request header size for embedded web server
> -------------------------------------------------------------
>
> Key: ARTEMIS-4939
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4939
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> In use-cases with large HTTP headers (e.g. using SSO) Jetty can choke on
> large headers and emit a message like:
> {noformat}
> 2024-07-12 11:41:32,875 WARN [org.eclipse.jetty.http.HttpParser] Header is
> too large 8193>8192{noformat}
> This should be configurable in {{bootstrap.xml}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
