[
https://issues.apache.org/jira/browse/ARTEMIS-4959?focusedWorklogId=927806&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-927806
]
ASF GitHub Bot logged work on ARTEMIS-4959:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jul/24 15:00
Start Date: 29/Jul/24 15:00
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5118:
URL: https://github.com/apache/activemq-artemis/pull/5118#discussion_r1695393912
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/QueueImpl.java:
##########
@@ -4484,6 +4484,10 @@ public Integer expectedHits() {
* @throws Exception
*/
public abstract boolean actMessage(Transaction tx, MessageReference ref)
throws Exception;
+
+ public boolean reachExpectedHits(int currentHits) {
Review Comment:
I would name it 'reachedExpectedHits' or my personal preference
'expectedHitsReached' to make the meaning more clear
Issue Time Tracking
-------------------
Worklog Id: (was: 927806)
Time Spent: 20m (was: 10m)
> moveMessages operation can move more messages than max messageCount
> -------------------------------------------------------------------
>
> Key: ARTEMIS-4959
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4959
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: management
> Affects Versions: 2.35.0
> Reporter: Howard Gao
> Assignee: Howard Gao
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When paging and many messages in a queue, the following is observed:
> $ bin/artemis producer --user admin --password admin --url
> tcp://localhost:61616 --message-count 10000 --message-size 10240
> --destination queue://FOO
> ...
> $ curl -XPOST -H "Content-Type: application/json" -H "Origin:
> http://localhost"; --user "admin:admin" -d
> '{"type":"exec","mbean":"org.apache.activemq.artemis:broker=\"0.0.0.0\",component=addresses,address=\"FOO\",subcomponent=queues,routing-type=\"anycast\",queue=\"FOO\"","operation":"moveMessages(int,java.lang.String,java.lang.String,boolean,int)","arguments":[500,"","DLQ",false,500]}'
> ...
>
> {"request":{"mbean":"org.apache.activemq.artemis:address=\"FOO\",broker=\"0.0.0.0\",component=addresses,queue=\"FOO\",routing-type=\"anycast\",subcomponent=queues","arguments":[500,"","DLQ",false,500],"type":"exec","operation":"moveMessages(int,java.lang.String,java.lang.String,boolean,int)"},"value":8630,"timestamp":1718395680,"status":200}
> Note that the messageCount for the moveMessages operation was 500, but in
> reality 8630 messages were moved (verified with queue stats). This does not
> seem to happen for queues with a low queue depth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
