[
https://issues.apache.org/jira/browse/ARTEMIS-4780?focusedWorklogId=929870&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-929870
]
ASF GitHub Bot logged work on ARTEMIS-4780:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Aug/24 15:45
Start Date: 12/Aug/24 15:45
Worklog Time Spent: 10m
Work Description: andytaylor commented on code in PR #21:
URL:
https://github.com/apache/activemq-artemis-console/pull/21#discussion_r1714021202
##########
artemis-console-extension/artemis-extension/public/artemisconfig.json:
##########
@@ -0,0 +1,5 @@
+{
+ "jmx": {
+ "domain": "org.apache.activemq.artemis"
+ }
+}
Review Comment:
> Is there some validation done in the pipelline at some point? I'm thinking
about a jsonschema of some sort.
There isn't, tbh I took this code from hawtIO, it is how they do it with
hawtconfig.json. I wouldnt know how to do whatyou suggest tbh.
Issue Time Tracking
-------------------
Worklog Id: (was: 929870)
Time Spent: 2h 40m (was: 2.5h)
> Artemis web console does not ever set 'artemisJmxDomain' in localStorage
> ------------------------------------------------------------------------
>
> Key: ARTEMIS-4780
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4780
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.32.0
> Reporter: Josh Byster
> Assignee: Andy Taylor
> Priority: Minor
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> We relocate our artemis packages as part of our shading process.
> I did set up:
>
> {code:java}
> aActiveMQServer.getConfiguration().setJMXDomain("com.abc.shaded.org.apache.activemq.artemis");
> {code}
> However the web console does not show up. I noticed in the code it's because
> we try to read in localStorage['artemisJmxDomain'] but never actually set it
> as far as I can tell. Thus we always default to org.apache.activemq.artemis.
> Everything works properly when setting localStorage['artemisJmxDomain'] =
> "com.abc.shaded.org.apache.activemq.artemis"
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact