[ 
https://issues.apache.org/jira/browse/ARTEMIS-4985?focusedWorklogId=929926&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-929926
 ]

ASF GitHub Bot logged work on ARTEMIS-4985:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Aug/24 19:56
            Start Date: 12/Aug/24 19:56
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #5142:
URL: https://github.com/apache/activemq-artemis/pull/5142#discussion_r1714299505


##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/collections/PriorityLinkedListImpl.java:
##########
@@ -54,6 +54,9 @@ public PriorityLinkedListImpl(final int priorities, 
Comparator<E> comparator) {
    }
 
    private void checkHighest(final int priority) {
+      for (int i = levels.length - 1; i >= 0 && levels[i].size() == 0; i--) {

Review Comment:
   Great catch! You're absolutely right. I looked at that code a lot, and my 
eyes just skipped right over that. Fixed.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 929926)
    Time Spent: 50m  (was: 40m)

> Message priority occasionally broken
> ------------------------------------
>
>                 Key: ARTEMIS-4985
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4985
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Sometimes a lower priority message may be dispatched before a higher priority 
> message.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to