[
https://issues.apache.org/jira/browse/ARTEMIS-4972?focusedWorklogId=930604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-930604
]
ASF GitHub Bot logged work on ARTEMIS-4972:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Aug/24 13:37
Start Date: 16/Aug/24 13:37
Worklog Time Spent: 10m
Work Description: jbertram commented on PR #5152:
URL:
https://github.com/apache/activemq-artemis/pull/5152#issuecomment-2293528006
There are also 6 checkstyle violations:
```
[INFO] There are 6 errors reported by Checkstyle 10.17.0 with
/home/runner/work/activemq-artemis/activemq-artemis/activemq-artemis/artemis-server/../etc/checkstyle.xml
ruleset.
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[326,7]
(blocks) LeftCurly: '{' at column 7 should be on the previous line.
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[332]
(regexp) RegexpSingleline: Line has trailing spaces.
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[332,7]
(blocks) RightCurly: '}' at column 7 should be on the same line as the next
part of a multi-block statement (one that directly contains multiple blocks:
if/else-if/else, do/while or try/catch/finally).
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[333]
(regexp) RegexpSingleline: Line has trailing spaces.
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[334,7]
(blocks) LeftCurly: '{' at column 7 should be on the previous line.
Error:
src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java:[337]
(regexp) RegexpSingleline: Line has trailing spaces.
```
You can [run checkstyle
yourself](https://activemq.apache.org/components/artemis/documentation/hacking-guide/#using-the-dev-profile)
locally using:
```
mvn -Pdev install
```
Issue Time Tracking
-------------------
Worklog Id: (was: 930604)
Time Spent: 0.5h (was: 20m)
> The start() method should use a lock to access the expected binding variables.
> ------------------------------------------------------------------------------
>
> Key: ARTEMIS-4972
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4972
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Suhov Roman
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> File:
> [https://github.com/apache/activemq-artemis/blob/2.36.0/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/group/impl/LocalGroupingHandler.java]
> Line: 325 - 327
>
> The start() method should use a lock to access the expectedBindings variable
> to ensure thread safety, since other methods use the lock and interact with
> expectedBindings at the same time.
> Using the lock in the start() method ensures that access to the
> expectedBindings variable is safe in a multi-threaded environment, preventing
> potential thread contention issues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
