[ 
https://issues.apache.org/jira/browse/ARTEMIS-5001?focusedWorklogId=932409&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932409
 ]

ASF GitHub Bot logged work on ARTEMIS-5001:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Aug/24 13:50
            Start Date: 29/Aug/24 13:50
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on PR #5172:
URL: 
https://github.com/apache/activemq-artemis/pull/5172#issuecomment-2317720246

   @gemmellr I am sorry, I think I have wasted your time here:
   
   
   This consistency level that I'm implementing here has already been used 
before, see:
   
   
https://github.com/apache/activemq-artemis/blob/7ca30e9a638e5192bfbe135585e5df9185b73cd7/artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java#L408-L416
   
   
   
   
   
   I guess this PR is a red herring from the fact I was : I - missing acks 
after replication, II - the retries were not effective
   
   
   
   I will keep the tweaks done in this PR... I will not touch 
OperationContextImpl as that's a very hot class. I will keep the comments only.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 932409)
    Time Spent: 5h 40m  (was: 5.5h)

> Add configuration option to relax syncs journal replication for Mirror Target
> -----------------------------------------------------------------------------
>
>                 Key: ARTEMIS-5001
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5001
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.37.0
>            Reporter: Clebert Suconic
>            Assignee: Clebert Suconic
>            Priority: Major
>             Fix For: 2.38.0
>
>          Time Spent: 5h 40m
>  Remaining Estimate: 0h
>
> When I worked on AMQP Mirror I did not actually envision being used with 
> journal replication. I actually thought more about adding multiple mirrored 
> options instead.
> However an user reported me that when using mirror and journal replication 
> combined, the sends could take a lot longer to happen (some normal latency) 
> and the acks would eventually be missed.
> I should add an option to ignore the replication for the Mirror Target.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to