[
https://issues.apache.org/jira/browse/ARTEMIS-5001?focusedWorklogId=932455&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932455
]
ASF GitHub Bot logged work on ARTEMIS-5001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Aug/24 16:30
Start Date: 29/Aug/24 16:30
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5172:
URL: https://github.com/apache/activemq-artemis/pull/5172#discussion_r1736648838
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AckManager.java:
##########
@@ -139,7 +140,14 @@ public void endRetry() {
// schedule a retry
if (!sortRetries().isEmpty()) {
- scheduledComponent.delay();
+ ActiveMQScheduledComponent scheduleComponentReference =
scheduledComponent;
+ if (scheduleComponentReference != null) {
+ try {
+ scheduleComponentReference.delay();
+ } catch (RejectedExecutionException thatsOK) {
+ logger.debug("Could not schedule an execution - {}",
thatsOK.getMessage(), thatsOK);
Review Comment:
```suggestion
logger.debug("Could not schedule AckManager retry task - {}",
thatsOK.getMessage(), thatsOK);
```
So that the message conveys _what_ didnt happen, otherwise I'd still need to
open the code.
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/impl/journal/OperationContextImpl.java:
##########
@@ -377,6 +428,30 @@ public String toString() {
}
}
+
+ static final class IgnoreReplicationTaskHolder {
+ @Override
+ public String toString() {
+ return "TaskHolder [storeLined=" + storeLined +
Review Comment:
I think you have unwound some fixups from earlier, this is back..or did I
imagine you fixing it already?
Issue Time Tracking
-------------------
Worklog Id: (was: 932455)
Time Spent: 6h 10m (was: 6h)
> Improve OperationContextImpl API to take ConsistencyLevel instead of a
> boolean true | false
> -------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5001
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5001
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> When I worked on AMQP Mirror I did not actually envision being used with
> journal replication. I actually thought more about adding multiple mirrored
> options instead.
> However an user reported me that when using mirror and journal replication
> combined, the sends could take a lot longer to happen (some normal latency)
> and the acks would eventually be missed.
> I should add an option to ignore the replication for the Mirror Target.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
