[
https://issues.apache.org/jira/browse/ARTEMIS-5023?focusedWorklogId=932659&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-932659
]
ASF GitHub Bot logged work on ARTEMIS-5023:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/24 15:03
Start Date: 30/Aug/24 15:03
Worklog Time Spent: 10m
Work Description: jbertram opened a new pull request, #5192:
URL: https://github.com/apache/activemq-artemis/pull/5192
Before the changes in 15dd24754ae8c6c2dd646fbd214f7a76b33b1197 temporary web
resources could proliferate and consume inordinate amounts of disk space
because their directory names were generated uniquely every time Jetty was
started. However, now that they are deterministic no proliferation is possible.
Jetty will create the directories when it starts, remove them when it stops,
and if it fails to clean-up on shutdown (e.g. crash from OOME) it will clean-up
and recreate them when it starts.
Therefore, our own house-keeping of those directories is no longer needed
and, in fact, causes problems. For example, when executing the
`restartEmbeddedWebServer` management operation the temp web resources will
actually be removed inadvertently causing the web console to fail.
This commit removes the web temp house-keeping logic as well as the related
tests. It also modifies & adds tests to ensure Jetty does this house-keeping on
its own.
Issue Time Tracking
-------------------
Worklog Id: (was: 932659)
Remaining Estimate: 0h
Time Spent: 10m
> Web temp directory cleaner is moot now
> --------------------------------------
>
> Key: ARTEMIS-5023
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5023
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Before the changes from ARTEMIS-4525 temporary web resources could
> proliferate and consume inordinate amounts of disk space because their
> directory names were generated uniquely every time Jetty was started.
> However, now that they are deterministic no proliferation is possible. Jetty
> will create the directories when it starts, remove them when it stops, and if
> it fails to clean-up on shutdown (e.g. crash from OOME) it will clean-up and
> recreate when it starts.
> Therefore, our own house-keeping of those directories is no longer needed
> and, in fact, causes problems. For example, when executing the
> {{restartEmbeddedWebServer}} management operation the temp web resources will
> actually be removed inadvertently causing the web console to fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
