[
https://issues.apache.org/jira/browse/ARTEMIS-5032?focusedWorklogId=933421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933421
]
ASF GitHub Bot logged work on ARTEMIS-5032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/24 15:59
Start Date: 05/Sep/24 15:59
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5216:
URL: https://github.com/apache/activemq-artemis/pull/5216#discussion_r1745809155
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/AMQPStandardMessage.java:
##########
@@ -235,10 +239,87 @@ public void reloadPersistence(ActiveMQBuffer record,
CoreMessageObjectPools pool
// Message state is now that the underlying buffer is loaded, but the
contents not yet scanned
resetMessageData();
+ recoverHeaderDataFromEncoding();
+
modified = false;
messageDataScanned = MessageDataScanningStatus.RELOAD_PERSISTENCE.code;
}
+ private void recoverHeaderDataFromEncoding() {
+ final DecoderImpl decoder = TLSEncode.getDecoder();
+ decoder.setBuffer(data);
Review Comment:
I mean.. I remember we would parse the header in out of order scenarios..
and we even had code.. I'm just wondering why you needed to add new code for
that?
Issue Time Tracking
-------------------
Worklog Id: (was: 933421)
Time Spent: 0.5h (was: 20m)
> Message priority not honored for persisted AMQP messages after server
> restarted
> -------------------------------------------------------------------------------
>
> Key: ARTEMIS-5032
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5032
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: AMQP
> Affects Versions: 2.37.0
> Reporter: Timothy A. Bish
> Assignee: Timothy A. Bish
> Priority: Minor
> Fix For: 2.38.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Messages sent with a non-default priority level that are persisted and later
> recovered after a server restart do not get delivered according to their
> original message priority but are all treated as having the default priority
> value (priority 4).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
