[
https://issues.apache.org/jira/browse/ARTEMIS-4965?focusedWorklogId=934037&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934037
]
ASF GitHub Bot logged work on ARTEMIS-4965:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/24 15:03
Start Date: 10/Sep/24 15:03
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5194:
URL: https://github.com/apache/activemq-artemis/pull/5194#discussion_r1752160146
##########
tests/artemis-test-support/src/main/java/org/apache/activemq/artemis/tests/util/ActiveMQTestBase.java:
##########
@@ -484,6 +484,7 @@ protected DatabaseStorageConfiguration
createDefaultDatabaseStorageConfiguration
// and we should only schedule one task
derbyDropped = true;
runAfterEx(this::dropDerby);
+ System.out.println("!!!!!!!!!!!!!!!!!!!!!!!!");
Review Comment:
:man_facepalming:
Issue Time Tracking
-------------------
Worklog Id: (was: 934037)
Time Spent: 1h 40m (was: 1.5h)
> Possible null dereference when property is missing in journal-sql.properties
> file
> ---------------------------------------------------------------------------------
>
> Key: ARTEMIS-4965
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4965
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Suhov Roman
> Assignee: Justin Bertram
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> File:
> https://github.com/apache/activemq-artemis/blob/main/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/sql/PropertySQLProvider.java
> In lines 81,93,94,95,101,106,111,116 and further in the PropertySQLProvider
> class, where properties are received from the journal-sql.properties file, a
> null dereference is possible.
> A dereference can occur if the required property is missing from the
> journal-sql.properties file. A null check must be added to all method return
> values.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
