[
https://issues.apache.org/jira/browse/ARTEMIS-5045?focusedWorklogId=934747&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934747
]
ASF GitHub Bot logged work on ARTEMIS-5045:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/24 15:35
Start Date: 13/Sep/24 15:35
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5230:
URL: https://github.com/apache/activemq-artemis/pull/5230#discussion_r1759081910
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/LegacyConfigMetricsPluginTest.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ * <br>
+ * http://www.apache.org/licenses/LICENSE-2.0
+ * <br>
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.activemq.artemis.tests.integration.plugin;
+
+import org.apache.activemq.artemis.core.config.MetricsConfiguration;
+import org.apache.activemq.artemis.core.server.ActiveMQServer;
+import
org.apache.activemq.artemis.core.server.metrics.plugins.SimpleMetricsPlugin;
+
+public class LegacyConfigMetricsPluginTest extends MetricsPluginTest {
+
+ @Override
+ protected void configureServer(ActiveMQServer server) {
+ server.getConfiguration().setMetricsConfiguration(new
MetricsConfiguration().setPlugin(new SimpleMetricsPlugin().init(null)));
Review Comment:
Nice catch!
Issue Time Tracking
-------------------
Worklog Id: (was: 934747)
Time Spent: 40m (was: 0.5h)
> Don't change the Micrometer MeterRegistry config
> ------------------------------------------------
>
> Key: ARTEMIS-5045
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5045
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> For embedded use-cases the Micrometer MeterRegistry may be passed in from the
> application and used for other meters unrelated to the broker. Therefore, the
> broker should not change the config of the MeterRegistry (e.g. by adding
> common tags to all meters) as the config change(s) may be incompatible with
> the needs of the embedding application.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
