[
https://issues.apache.org/jira/browse/ARTEMIS-5048?focusedWorklogId=935347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935347
]
ASF GitHub Bot logged work on ARTEMIS-5048:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/24 14:05
Start Date: 19/Sep/24 14:05
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5234:
URL: https://github.com/apache/activemq-artemis/pull/5234#discussion_r1766903808
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/Base64.java:
##########
@@ -1,1619 +1,61 @@
-/**
- * This file is released into the public domain.
Review Comment:
See #5240.
Issue Time Tracking
-------------------
Worklog Id: (was: 935347)
Time Spent: 1h 50m (was: 1h 40m)
> Use java.util.Base64
> --------------------
>
> Key: ARTEMIS-5048
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5048
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> We've traditionally used {{org.apache.activemq.artemis.utils.Base64}} for
> Base64 encoding/decoding. This implementation is based on public domain code
> from http://iharder.net/base64.
> In Java 8 {{java.util.Base64}} was introduced. I assumed we hadn't switched
> to this implementation for performance reasons so I created a simple
> JMH-based test to compare the two implementations and it appears to me that
> {{java.util.Base64}} is significantly faster than our current implementation.
> Using the JDK's class will simplify our code _and_ improve performance. Also,
> it should be 100% backwards compatible since Base64 encoding/decoding is
> standardized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
