[
https://issues.apache.org/jira/browse/ARTEMIS-4680?focusedWorklogId=935351&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-935351
]
ASF GitHub Bot logged work on ARTEMIS-4680:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Sep/24 14:32
Start Date: 19/Sep/24 14:32
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #32:
URL:
https://github.com/apache/activemq-artemis-console/pull/32#discussion_r1766950395
##########
.github/workflows/build.yml:
##########
@@ -26,5 +26,26 @@ jobs:
if: failure()
uses: actions/upload-artifact@v4
with:
- name: rat
- path: target/rat.txt
\ No newline at end of file
+ name: rat-${{ matrix.java }}
+ path: target/rat.txt
+
+ - name: Upload Rat Report On Failure
+ if: failure()
+ uses: actions/upload-artifact@v4
+ with:
+ name: rat-distribution-${{ matrix.java }}
+ path: artemis-console-distribution/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+ if: failure()
+ uses: actions/upload-artifact@v4
+ with:
+ name: rat-extension-${{ matrix.java }}
+ path: artemis-console-extension/target/rat.txt
+
+ - name: Upload Rat Report On Failure
+ if: failure()
+ uses: actions/upload-artifact@v4
+ with:
+ name: rat-console-${{ matrix.java }}
+ path: artemis-console-war/target/rat.txt
Review Comment:
Having lots of steps doing essentially the same overall thing, and which are
likely to individually fail themselves if the file doenst exist (job could fail
for other reasons) seems less than ideal. The per-module nature of it is also
brittle in terms of handling any future additions and renames.
Should be able to do it in one step, with one upload, and which doesnt fail
if there are no rat.txt files.
https://github.com/actions/upload-artifact?tab=readme-ov-file#upload-using-a-wildcard-pattern
https://github.com/actions/upload-artifact?tab=readme-ov-file#customization-if-no-files-are-found
Issue Time Tracking
-------------------
Worklog Id: (was: 935351)
Time Spent: 14.5h (was: 14h 20m)
> Upgrade the console to use HawtIO 4
> -----------------------------------
>
> Key: ARTEMIS-4680
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4680
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Web Console
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Fix For: console-1.0.0
>
> Time Spent: 14.5h
> Remaining Estimate: 0h
>
> The current console is based upon HawtIO 1 which in turn is built on
> Bootstrap. Bootstrap is old and no longer actively being maintained.
>
> This improvement is to migrate the current console to use HawtIO 4 which i
> based on Typescript, react and Patternfly.
>
> As it can run standalone and be built seperately, this will be released
> independently from [https://github.com/apache/activemq-artemis-console] and
> the output later consumed in Artemis releases (similar to artemis-native).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
