[
https://issues.apache.org/jira/browse/ARTEMIS-5097?focusedWorklogId=937604&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-937604
]
ASF GitHub Bot logged work on ARTEMIS-5097:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Oct/24 14:20
Start Date: 11/Oct/24 14:20
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5290:
URL: https://github.com/apache/activemq-artemis/pull/5290#discussion_r1797031413
##########
artemis-cli/src/main/java/org/apache/activemq/artemis/cli/commands/tools/xml/XmlDataExporter.java:
##########
@@ -80,6 +80,12 @@ public final class XmlDataExporter extends DBOption {
private XMLStreamWriter xmlWriter;
+ private Throwable lastError;
+
+ // I am creating a hidden feature now, in case users ever ask to expose
this, it would be already here.
+ @Option(names = "undefined-prefix", hidden = true, description = "In case a
queue does not exist, this will define the prefix to be used on the message
export.")
Review Comment:
Well, I think it makes sense, and I also think it's worth a full explanation
of the use-case in the documentation (which I plan on writing after this is
merged).
I wouldn't change the handling if there's just one queue missing. That's
just more complexity to explain & maintain without much real benefit.
Issue Time Tracking
-------------------
Worklog Id: (was: 937604)
Time Spent: 40m (was: 0.5h)
> ./artemis data exp | imp should deal with deleted queues
> --------------------------------------------------------
>
> Key: ARTEMIS-5097
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5097
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.37.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Fix For: 2.38.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> say you delete a queue, the ./artemis data exp (Export tool) and Import tool
> should be able to deal with undefined queues.
> The use case here comes from an user who deleted the queue by accident and
> their data went to be removed after a restart of the broker.
> ./artemis data recover would be able to recover the information but the
> export would fail.
> With this modification these tools would be able to deal with undefined
> queues.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
