[ 
https://issues.apache.org/jira/browse/AMQ-9596?focusedWorklogId=939280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939280
 ]

ASF GitHub Bot logged work on AMQ-9596:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Oct/24 18:19
            Start Date: 21/Oct/24 18:19
    Worklog Time Spent: 10m 
      Work Description: mattrpav commented on code in PR #1326:
URL: https://github.com/apache/activemq/pull/1326#discussion_r1809280575


##########
activemq-client/src/main/java/org/apache/activemq/util/ProducerThread.java:
##########
@@ -40,6 +40,8 @@ public class ProducerThread extends Thread {
     long msgTTL = 0L;
     String msgGroupID=null;
     int transactionBatchSize;
+    int priority = 4;

Review Comment:
   This should use the Jakarta Messaging API constant instead of fix value. 
jakarta.jms.Message.DEFAULT_PRIORITY



##########
activemq-console/src/main/java/org/apache/activemq/console/command/ProducerCommand.java:
##########
@@ -45,6 +45,8 @@ public class ProducerCommand extends AbstractCommand {
     String msgGroupID=null;
     int transactionBatchSize;
     private int parallelThreads = 1;
+    int priority = 4; // Default priority

Review Comment:
   1. This should use the Jakarta Messaging API constant instead of fix value. 
jakarta.jms.Message.DEFAULT_PRIORITY
   
   2. Remove comment





Issue Time Tracking
-------------------

    Worklog Id:     (was: 939280)
    Time Spent: 0.5h  (was: 20m)

> Add more options to activemq-console producer command
> -----------------------------------------------------
>
>                 Key: AMQ-9596
>                 URL: https://issues.apache.org/jira/browse/AMQ-9596
>             Project: ActiveMQ Classic
>          Issue Type: Improvement
>          Components: Command Line Tools
>    Affects Versions: 6.1.3, 5.18.6
>            Reporter: Ken Liao
>            Assignee: Ken Liao
>            Priority: Minor
>             Fix For: 6.2.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Right now a user can create a simple producer by running the activemq CLI
> {{./activemq producer <options>}}
> However it doesn't support the following:
> - Setting the message priority (the broker will need to enable prioritized 
> message support on those destinations)
> - Setting the delay in delivery
> - Setting disableMessageTimestamp
> The scope of this ticket is to support those options on the producer command.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to