[
https://issues.apache.org/jira/browse/ARTEMIS-5110?focusedWorklogId=939543&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939543
]
ASF GitHub Bot logged work on ARTEMIS-5110:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Oct/24 16:50
Start Date: 22/Oct/24 16:50
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5303:
URL: https://github.com/apache/activemq-artemis/pull/5303#discussion_r1811075534
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQServerLogger.java:
##########
@@ -35,30 +32,26 @@
import org.apache.activemq.artemis.core.config.Configuration;
import org.apache.activemq.artemis.core.io.IOCallback;
import org.apache.activemq.artemis.core.io.SequentialFile;
-import org.apache.activemq.artemis.core.paging.cursor.PagePosition;
-import org.apache.activemq.artemis.core.paging.cursor.PageSubscription;
-import org.apache.activemq.artemis.core.persistence.OperationContext;
import org.apache.activemq.artemis.core.protocol.core.Packet;
import
org.apache.activemq.artemis.core.protocol.core.impl.wireformat.BackupReplicationStartFailedMessage;
import org.apache.activemq.artemis.core.remoting.impl.netty.TransportConstants;
-import org.apache.activemq.artemis.core.server.routing.targets.Target;
import org.apache.activemq.artemis.core.server.cluster.Bridge;
import org.apache.activemq.artemis.core.server.cluster.impl.BridgeImpl;
import
org.apache.activemq.artemis.core.server.cluster.impl.ClusterConnectionImpl;
import
org.apache.activemq.artemis.core.server.cluster.quorum.ServerConnectVote;
import org.apache.activemq.artemis.core.server.impl.ActiveMQServerImpl;
import org.apache.activemq.artemis.core.server.impl.ServerSessionImpl;
import org.apache.activemq.artemis.core.server.management.Notification;
+import org.apache.activemq.artemis.core.server.routing.targets.Target;
+import org.apache.activemq.artemis.logs.BundleFactory;
import org.apache.activemq.artemis.logs.annotation.LogBundle;
import org.apache.activemq.artemis.logs.annotation.LogMessage;
-import org.apache.activemq.artemis.logs.BundleFactory;
import org.apache.activemq.artemis.spi.core.remoting.Connection;
-import org.w3c.dom.Node;
/**
* Logger Code 22
*/
-@LogBundle(projectCode = "AMQ", regexID = "22[0-9]{4}")
+@LogBundle(projectCode = "AMQ", regexID = "22[0-9]{4}", retiredIDs = "221026,
221052, 222012, 222020, 222021, 222022, 222024, 222027, 222028, 222029, 222052,
222071, 222078, 222079, 222083, 222084, 222088, 222090, 222102, 222128, 222134,
222135, 222152, 222159, 222163, 222167, 222170, 222171, 222182, 222192, 222193,
222204, 222252, 222255, 222257, 224001, 224002, 224003, 224005, 224035, 224100,
224121, 224127, 222260, 222259, 222288")
Review Comment:
How about something like this?
```java
@LogBundle(
projectCode = "AMQ",
regexID = "22[0-9]{4}",
retiredIDs = {
221026,
221052,
222012,
222020,
222021,
222022,
222024,
222027,
222028,
222029,
222052,
222071,
222078,
222079,
222083,
222084,
222088,
222090,
222102,
222128,
222134,
222135,
222152,
222159,
222163,
222167,
222170,
222171,
222182,
222192,
222193,
222204,
222252,
222255,
222257,
224001,
224002,
224003,
224005,
224035,
224100,
224121,
224127,
222260,
222259,
222288})
```
Issue Time Tracking
-------------------
Worklog Id: (was: 939543)
Time Spent: 1h 50m (was: 1h 40m)
> Add ability to identify retired IDs in log annotations
> ------------------------------------------------------
>
> Key: ARTEMIS-5110
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5110
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The broker uses unique IDs for logging statements. As logging changes over
> time we need a way to "retire" these IDs (e.g. when certain logging
> statements are no longer needed) to ensure they are not used again in the
> future (or perhaps put back into the rotation after a certain amount of time).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
