[
https://issues.apache.org/jira/browse/ARTEMIS-5131?focusedWorklogId=939763&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939763
]
ASF GitHub Bot logged work on ARTEMIS-5131:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/24 17:22
Start Date: 23/Oct/24 17:22
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #5316:
URL: https://github.com/apache/activemq-artemis/pull/5316#discussion_r1813223555
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/QueueControlTest.java:
##########
@@ -2618,6 +2618,60 @@ public void testMoveMessage() throws Exception {
session.deleteQueue(otherQueue);
}
+ @TestTemplate
Review Comment:
For adding a feature like this you should ideally write a test that covers
more of the protocols and messages (normal or large) as well as times when
paging is happening vs not as there have been a number of cases lately where a
breakage or misbehavior has been found when an AMQP or a Large message was
involved in internal management code such as this.
Refer to test:
[tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/BeforeSendPluginTest.java](https://github.com/apache/activemq-artemis/blob/24fb38c86f5367865741e2fdea5773ec41da0685/tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/plugin/BeforeSendPluginTest.java)
for some inspiration
Issue Time Tracking
-------------------
Worklog Id: (was: 939763)
Time Spent: 0.5h (was: 20m)
> Add A Copy message button to console
> ------------------------------------
>
> Key: ARTEMIS-5131
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5131
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Andy Taylor
> Assignee: Andy Taylor
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This would behave similarly to the move button and would neeed some additions
> to QueueControl
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
