[
https://issues.apache.org/jira/browse/AMQ-9548?focusedWorklogId=939802&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939802
]
ASF GitHub Bot logged work on AMQ-9548:
---------------------------------------
Author: ASF GitHub Bot
Created on: 23/Oct/24 19:21
Start Date: 23/Oct/24 19:21
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1288:
URL: https://github.com/apache/activemq/pull/1288#issuecomment-2433250908
@jbonofre and @mattrpav -
I took a look at this and I agree with Matt for all the points he made. The
suppression configuration here is because of performance reasons. You are
suppressing the returned queue metrics over JMX to not overload things. That
doesn't mean the queues don't exist or are not valid so I don't think it makes
sense to hide suppressed queues from the metrics. On the other hand I get JB's
point about it could be a little confusing if getQueues() is returning a
different number because of the suppression.
So if I had to pick one I would agree with @mattrpav and say we should
return total queues. However, why not just provide both and call it a day? Just
provide both a total count for the broker of the over all queue count and also
a suppressed count metric.
We could have something like getTotalQueueCount() and
getSupressedQueueCount() or something like that. The total queues just can just
use the map size with is a fast constant operation as @mattrpav pointed out.
For suppressed queues you could iterate over the queues in the map and count
them to avoid object allocation on the broker side, or we could just keep a
counter that keeps a running total on queue adds/deletes.
Issue Time Tracking
-------------------
Worklog Id: (was: 939802)
Time Spent: 8h (was: 7h 50m)
> Add new broker mbean attributes to directly retrieve total number of queues
> and topics
> --------------------------------------------------------------------------------------
>
> Key: AMQ-9548
> URL: https://issues.apache.org/jira/browse/AMQ-9548
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Components: JMX
> Affects Versions: 5.18.5, 6.1.2
> Reporter: Ken Liao
> Assignee: Ken Liao
> Priority: Major
> Fix For: 6.2.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> Right now, to monitor the number of destination, the only way is to read the
> destinations MBean and get the total destination. However, this means reading
> all destination names into memory, if the user has 10K+ destination with long
> destination name, it will be a large amount of memory just to monitor the
> number of them.
> The proposal here is to add either a new MBean value or a method to obtain
> that data. We can also add a method to retrieve the first K destination as
> well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
