[
https://issues.apache.org/jira/browse/ARTEMIS-5148?focusedWorklogId=943329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-943329
]
ASF GitHub Bot logged work on ARTEMIS-5148:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Nov/24 14:02
Start Date: 12/Nov/24 14:02
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5338:
URL: https://github.com/apache/activemq-artemis/pull/5338#discussion_r1838156501
##########
tests/soak-tests/src/test/java/org/apache/activemq/artemis/tests/soak/interruptlm/ClusteredLargeMessageInterruptTest.java:
##########
@@ -375,21 +344,20 @@ private void testInterruptFailOnBridge(String protocol,
boolean tx) throws Throw
ExecutorService executorService =
Executors.newFixedThreadPool(SENDING_THREADS + CONSUMING_THREADS);
runAfter(executorService::shutdownNow);
- // only start the sender for a while
CountDownLatch sendDone = startSendingThreads(executorService, protocol,
0, SENDING_THREADS, tx, queueName);
Thread.sleep(2000);
runningSend = runningConsumer = false;
- killProcess(serverProcess, false);
- assertTrue(serverProcess.waitFor(10, TimeUnit.MINUTES));
+ killProcess(serverProcess);
+ assertTrue(serverProcess.waitFor(1, TimeUnit.MINUTES));
assertTrue(sendDone.await(10, TimeUnit.SECONDS));
sendDone = startSendingThreads(executorService, protocol, 1,
SENDING_THREADS, tx, queueName);
CountDownLatch receiverDone = startConsumingThreads(executorService,
protocol, 1, CONSUMING_THREADS, tx, queueName);
- killProcess(serverProcess, false);
- assertTrue(serverProcess.waitFor(10, TimeUnit.SECONDS));
+ killProcess(serverProcess);
+ assertTrue(serverProcess.waitFor(1, TimeUnit.MINUTES));
Review Comment:
I did it as a precaution as I said earlier ^^
Issue Time Tracking
-------------------
Worklog Id: (was: 943329)
Time Spent: 1h (was: 50m)
> Simpllify and make ClusteredLargeMessageInterruptTest more reliable
> -------------------------------------------------------------------
>
> Key: ARTEMIS-5148
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5148
> Project: ActiveMQ Artemis
> Issue Type: Test
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Minor
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> As I was writing the test ClusteredLargeMessageInterruptTest I was trying
> many permutations, tinkering / hacking to reproduce an issue it was reported
> to me in production. once I found it I created
> AmqpLargeMessageTest::testDeleteUnreferencedMessage,
> and I ended up leaving the test in its last permutation thinking it would be
> a good thing.. however the test is failing for test issues in itself
> (consumers not being closed.. and test races). The main purpose of the test
> is to accumulate messages in the SNF and kill the servers.
> So as part of this task I'm simplifying the test making it more reliable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
