[
https://issues.apache.org/jira/browse/ARTEMIS-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899516#comment-17899516
]
ASF subversion and git services commented on ARTEMIS-5155:
----------------------------------------------------------
Commit d4fff2fd580d4cdc2de276dcc9bad83120aa5f25 in activemq-artemis's branch
refs/heads/main from Timothy Bish
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d4fff2fd58 ]
ARTEMIS-5155 Race on AMQP large message read and close
When the final frame of a large message is being written to the file in
the session thread and an IO error occurs such that that connection is
torn down, the large message reader can be closed before the message is
fully processed resulting in corruption. The large message file close
logic needs to occur on the session thread so that the processing of the
bytes can finish and the message gets added to the Queue and the close
can react by not deleting the file when it runs following the read task.
> AMQP LargeMessage file can be deleted in error on connection drop if final
> frame is being processed
> ---------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> When sending a large message the file should be closed before calling advance
> and performing further storage operations.
> This is regressed after
> c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
> Where the file.close was moved to the finalize block after the delivery...
> causing a possible race over a server's failure.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
