[
https://issues.apache.org/jira/browse/ARTEMIS-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Timothy A. Bish updated ARTEMIS-5155:
-------------------------------------
Description:
This is to fix tests in LargeMessageInterruptTest.
The changes to move large message handling into the session thread apart from
the connection thread introduced a race if the final frame of a large message
is being handled and an IO error triggers shutdown of the AMQP link closing the
large message reader and deleting the in-progross large message file while
still allowing the message to be enqueued resulting in a corrupt message.
was:
This is to fix tests in LargeMessageInterruptTest.
When sending a large message the file should be closed before calling advance
and performing further storage operations.
This is regressed after
c83ed8957d9d7f06bb29c0fce563fe2e3462993e / ARTEMIS-4668
Where the file.close was moved to the finalize block after the delivery...
causing a possible race over a server's failure.
> AMQP LargeMessage file can be deleted in error on connection drop if final
> frame is being processed
> ---------------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5155
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5155
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.38.0
> Reporter: Clebert Suconic
> Assignee: Timothy A. Bish
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> This is to fix tests in LargeMessageInterruptTest.
> The changes to move large message handling into the session thread apart from
> the connection thread introduced a race if the final frame of a large message
> is being handled and an IO error triggers shutdown of the AMQP link closing
> the large message reader and deleting the in-progross large message file
> while still allowing the message to be enqueued resulting in a corrupt
> message.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
