[
https://issues.apache.org/jira/browse/ARTEMIS-5166?focusedWorklogId=944633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944633
]
ASF GitHub Bot logged work on ARTEMIS-5166:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/24 17:56
Start Date: 20/Nov/24 17:56
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5357:
URL: https://github.com/apache/activemq-artemis/pull/5357#discussion_r1850279614
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/remoting/ReconnectTest.java:
##########
@@ -195,19 +189,13 @@ public void internalMetadataAfterRetry(final boolean
isNetty) throws Exception {
}
- private ServerSession[] countMetadata(ActiveMQServer server, String
parameter, int expected) throws Exception {
+ private ServerSession[] getSessionsWithMetadata(ActiveMQServer server,
String parameter) throws Exception {
List<ServerSession> sessionList = new LinkedList<>();
- for (int i = 0; i < 10 && sessionList.size() != expected; i++) {
- sessionList.clear();
- for (ServerSession sess : server.getSessions()) {
- if (sess.getMetaData(parameter) != null) {
- sessionList.add(sess);
- }
- }
-
- if (sessionList.size() != expected) {
- Thread.sleep(100);
+ sessionList.clear();
Review Comment:
A new list shouldnt need cleared
Issue Time Tracking
-------------------
Worklog Id: (was: 944633)
Time Spent: 20m (was: 10m)
> Improve reliability of ReconnectTest
> ------------------------------------
>
> Key: ARTEMIS-5166
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5166
> Project: ActiveMQ Artemis
> Issue Type: Test
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.39.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
