[ 
https://issues.apache.org/jira/browse/AMQ-9593?focusedWorklogId=946198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-946198
 ]

ASF GitHub Bot logged work on AMQ-9593:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 30/Nov/24 02:20
            Start Date: 30/Nov/24 02:20
    Worklog Time Spent: 10m 
      Work Description: mattrpav commented on code in PR #1352:
URL: https://github.com/apache/activemq/pull/1352#discussion_r1864047656


##########
activemq-broker/src/main/java/org/apache/activemq/broker/BrokerService.java:
##########
@@ -184,6 +184,7 @@ public class BrokerService implements Service {
     private JmsConnector[] jmsBridgeConnectors; // these are Jms to Jms bridges
     // to other jms messaging systems
     private boolean deleteAllMessagesOnStartup;
+    private boolean deleteAllScheduledMessagesOnStartup = false;

Review Comment:
   Scheduled message support is part of the JMS 3.1/2.0 spec. I'm not loving 
the separate config flag. We don't have a 
'deleteAllDurableTopicMessagesOnStartup' flag. It just 
'deleteAllmessagesOnStartup'.
   
   I'm thinking it would be better to have a flag to have the scheduler 
_ignore_ the deleteAllMessagesOnStartup.
   
   Possible path forward:
   v6.x - Scheduler ignores deleteAllMessagesOnStartup by default (to maintain 
existing behavior)
   v7.x - Scheduler honors deleteAllMessagesOnStartup by default





Issue Time Tracking
-------------------

            Worklog Id:     (was: 946198)
    Remaining Estimate: 0h
            Time Spent: 10m

> Add a new option to delete all scheduled messages on startup
> ------------------------------------------------------------
>
>                 Key: AMQ-9593
>                 URL: https://issues.apache.org/jira/browse/AMQ-9593
>             Project: ActiveMQ Classic
>          Issue Type: Improvement
>          Components: Job Scheduler
>            Reporter: Ken Liao
>            Assignee: Ken Liao
>            Priority: Major
>             Fix For: 6.2.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Right now there is no way to delete scheduled messages on startup because it 
> is stored separately from the KahaDB message store. As a result 
> "deleteAllMessagesOnStartup" will not delete scheduled messages as expected.
> Nevertheless, it can be useful to provide an option to clean all scheduled 
> message upon restart. This provides a way for users to reset the job 
> scheduler.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to