[
https://issues.apache.org/jira/browse/AMQ-8324?focusedWorklogId=947851&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947851
]
ASF GitHub Bot logged work on AMQ-8324:
---------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/24 19:26
Start Date: 11/Dec/24 19:26
Worklog Time Spent: 10m
Work Description: kenliao94 commented on PR #1364:
URL: https://github.com/apache/activemq/pull/1364#issuecomment-2536928048
Hi @cshannon so the goal here is to implement the behavior as close to the
spec as possible. There are 9 items in the spec, so are we saying that only
7.3.3 message orders is not met?
In another words:
7.3.1 - met
7.3.2 - met
7.3.3 - not met
7.3.4 - met
7.3.5 - no going to support it, met
7.3.6 - not going to throw exception, it is application responsibility, met
7.3.7 - met
7.3.8 - I thought this is already met, but it seems like it has
7.3.9 - not going to throw exception, it is application responsibility, met
The first iteration of this PR is to just wrap AsyncCallback into
CompletionListener and have the CompletionListener implemented the same way as
the original AsyncCallback. But as @tabish121 pointed out that version didn't
implement the spec from the mailing list discussion
https://lists.apache.org/thread/y2pz4y1p9c5l1cdm6lyd5spc810mk6kq we want to
keep both behavior in ActiveMQ 6. Hence I created another PR that referenced
the current design but added additional logic (wrapping user completion
listener to perform check)
I will do more testing and add more logic to try and meet 7.3.3. But would
like to get clarity on whether this is the only one not meeting the spec or
there are more. Thanks.
Issue Time Tracking
-------------------
Worklog Id: (was: 947851)
Time Spent: 3h 10m (was: 3h)
> Implement JMS 2.0 MessageProducer CompletionListener methods
> ------------------------------------------------------------
>
> Key: AMQ-8324
> URL: https://issues.apache.org/jira/browse/AMQ-8324
> Project: ActiveMQ Classic
> Issue Type: New Feature
> Reporter: Matt Pavlovich
> Assignee: Matt Pavlovich
> Priority: Major
> Labels: #jms2
> Fix For: 6.2.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> CompletionListener, etc
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
