[
https://issues.apache.org/jira/browse/ARTEMIS-5210?focusedWorklogId=948058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-948058
]
ASF GitHub Bot logged work on ARTEMIS-5210:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/24 16:11
Start Date: 12/Dec/24 16:11
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5395:
URL: https://github.com/apache/activemq-artemis/pull/5395#discussion_r1882453108
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/utils/bean/MetaBean.java:
##########
@@ -123,10 +123,9 @@ public void parseToJSON(T object, JsonObjectBuilder
builder, boolean ignoreNullA
}
} else if (type == Boolean.class) {
builder.add(name, (Boolean) value);
+ /* This is the same as the default, but keeping this in case we
have to deal with Enums in the future
} else if (Enum.class.isAssignableFrom(type)) {
- // I know this is the same as the default else clause further
down
- // but i wanted to have a separate branch in case we have to
deal with it later
- builder.add(name, String.valueOf(value));
+ builder.add(name, String.valueOf(value));*/
Review Comment:
I'm fine with deleting this, but I left it in to be conservative.
Issue Time Tracking
-------------------
Worklog Id: (was: 948058)
Time Spent: 50m (was: 40m)
> Bump com.google.errorprone:error_prone_core from 2.31.0 to 2.36.0
> -----------------------------------------------------------------
>
> Key: ARTEMIS-5210
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5210
> Project: ActiveMQ Artemis
> Issue Type: Dependency upgrade
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
