[
https://issues.apache.org/jira/browse/ARTEMIS-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914626#comment-17914626
]
Robbie Gemmell commented on ARTEMIS-5209:
-----------------------------------------
(duped comment from the PR)
As you noticed prior to your PR, the broker already supports duplicate
detection with AMQP messages, in the same general way it does for e.g Core and
other protocol usages, via message [application-]properties. This was added in
some time ago, in ARTEMIS-2294. There are existing tests from that time, though
I did just make and improvement to them.
There isnt a specific note on the AMQP page for duplicate detection as it
really notes behaviours specific to the AMQP support, whilst for duplicate
detection the same general docs on duplicate detection apply to all the
protocols and are a better fit. I did reorder and tweak the doc to emphasize
the more general details first, before a note of the detail for just the Core
client API.
Both the tweaks I made are in
https://github.com/apache/activemq-artemis/commit/89b3ebb077b203dd0c9ae3b85983d6b2ac1231e9
and I updated the Jira to reflect that, but thanks for the contribution!
> Tweak duplicate detection docs, improve AMQP test
> -------------------------------------------------
>
> Key: ARTEMIS-5209
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5209
> Project: ActiveMQ Artemis
> Issue Type: Task
> Components: AMQP
> Reporter: Guilherme Salustiano
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Tweak the duplicate detection docs for clarity, and improve the existing AMQP
> test for duplicate detection.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
