[ 
https://issues.apache.org/jira/browse/ARTEMIS-5254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916198#comment-17916198
 ] 

Justin Bertram edited comment on ARTEMIS-5254 at 1/22/25 9:51 PM:
------------------------------------------------------------------

The very brief comments in the code you pasted (i.e. "need replace") do not 
provide enough information to understand the problem. Please elaborate on what 
exactly the problem is (ideally with a way to reproduce it) otherwise this 
issue will be closed. Thanks!


was (Author: jbertram):
The very brief comments in the code you pasted do not provide enough 
information to understand the problem. Please elaborate on what exactly the 
problem is (ideally with a way to reproduce it) otherwise this issue will be 
closed. Thanks!

> MQTTSession.stop failure: Parameters not enabled.
> -------------------------------------------------
>
>                 Key: ARTEMIS-5254
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5254
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>    Affects Versions: 2.38.0
>            Reporter: gongping.zhu
>            Priority: Major
>
> void stop(boolean failure) throws Exception {
> state.setFailed(failure);
> if (!stopped) {
> protocolHandler.stop();
> subscriptionManager.stop();
> mqttPublishManager.stop();
> if (serverSession != null) {
> serverSession.stop();
> serverSession.close(false);//need replace
> }
> if (internalServerSession != null) {
> internalServerSession.stop();
> internalServerSession.close(false);//need replace
> }
> state.setAttached(false);//need replace
> state.setDisconnectedTime(System.currentTimeMillis());
> state.clearTopicAliases();
> if (getVersion() == MQTTVersion.MQTT_5) {
> if (state.getClientSessionExpiryInterval() == 0) {
> if (state.isWill() && failure) {
> // If the session expires the will message must be sent no matter the will 
> delay
> sendWillMessage();
> }
> clean(false);
> stateManager.removeSessionState(connection.getClientID());
> }
> } else {
> if (state.isWill() && failure) {
> sendWillMessage();
> }
> if (isClean()) {
> clean(false);
> stateManager.removeSessionState(connection.getClientID());
> }
> }
> }
> stopped = true;
> }



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to