[
https://issues.apache.org/jira/browse/ARTEMIS-5292?focusedWorklogId=955171&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955171
]
ASF GitHub Bot logged work on ARTEMIS-5292:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/25 10:39
Start Date: 03/Feb/25 10:39
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5479:
URL: https://github.com/apache/activemq-artemis/pull/5479#discussion_r1939148866
##########
artemis-jakarta-cdi-client/pom.xml:
##########
@@ -0,0 +1,227 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.40.0-SNAPSHOT</version>
+ <relativePath>../artemis-pom/pom.xml</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>artemis-jakarta-cdi-client</artifactId>
+ <name>ActiveMQ Artemis CDI Integration</name>
Review Comment:
Differentiate the name, e.g. ActiveMQ Artemis Jakarta CDI Integration, so
its clear when building which module Maven was referring to in the summary.
##########
artemis-cdi-client/src/main/java/org/apache/artemis/client/cdi/extension/ArtemisClientConfigBean.java:
##########
@@ -45,7 +45,8 @@ public Set<InjectionPoint> getInjectionPoints() {
return emptySet();
}
- @Override
+ // we cannot use @Override here because otherwise the build of
artemis-cdi-jakarta-client fails since the method was removed in jakarta ee 9+
Review Comment:
Still need to update the module name following its rename.
(same in other class changed)
##########
artemis-bom/pom.xml:
##########
@@ -233,6 +233,11 @@
<artifactId>artemis-website</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-jakarta-cdi-client</artifactId>
+ <version>${project.version}</version>
+ </dependency>
Review Comment:
Move this up with the other jakarta modules, sorted alphabetically.
##########
artemis-jakarta-cdi-client/pom.xml:
##########
@@ -0,0 +1,227 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+ ~ Licensed to the Apache Software Foundation (ASF) under one
+ ~ or more contributor license agreements. See the NOTICE file
+ ~ distributed with this work for additional information
+ ~ regarding copyright ownership. The ASF licenses this file
+ ~ to you under the Apache License, Version 2.0 (the
+ ~ "License"); you may not use this file except in compliance
+ ~ with the License. You may obtain a copy of the License at
+ ~
+ ~ http://www.apache.org/licenses/LICENSE-2.0
+ ~
+ ~ Unless required by applicable law or agreed to in writing,
+ ~ software distributed under the License is distributed on an
+ ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~ KIND, either express or implied. See the License for the
+ ~ specific language governing permissions and limitations
+ ~ under the License.
+ -->
+
+<project xmlns="http://maven.apache.org/POM/4.0.0";
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd";>
+ <parent>
+ <groupId>org.apache.activemq</groupId>
+ <artifactId>artemis-pom</artifactId>
+ <version>2.40.0-SNAPSHOT</version>
+ <relativePath>../artemis-pom/pom.xml</relativePath>
+ </parent>
+ <modelVersion>4.0.0</modelVersion>
+
+ <artifactId>artemis-jakarta-cdi-client</artifactId>
+ <name>ActiveMQ Artemis CDI Integration</name>
+
+ <properties>
+
<jakarta.inject-api.version>${jakarta.inject-api.version.alt}</jakarta.inject-api.version>
+
<jakarta.annotation-api.version>${jakarta.annotation-api.version.alt}</jakarta.annotation-api.version>
+
<jakarta.enterprise.cdi-api.version>${jakarta.enterprise.cdi-api.version.alt}</jakarta.enterprise.cdi-api.version>
+
<jakarta.jms-api.version>${jakarta.jms-api.version.alt}</jakarta.jms-api.version>
+
<jakarta.transaction-api.version>${jakarta.transaction-api.version.alt}</jakarta.transaction-api.version>
+
<jakarta.ejb-api.version>${jakarta.ejb-api.version.alt}</jakarta.ejb-api.version>
+ <weld.version>${weld.version.alt}</weld.version>
+
<arquillian-weld-embedded.version>${arquillian-weld-embedded.version.alt}</arquillian-weld-embedded.version>
+ <owb.version>${owb.version.alt}</owb.version>
+ </properties>
+
+ <dependencies>
+ <!
Issue Time Tracking
-------------------
Worklog Id: (was: 955171)
Time Spent: 20m (was: 10m)
> Introduce jakarta version of artemis-cdi-client
> -----------------------------------------------
>
> Key: ARTEMIS-5292
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5292
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Reporter: Christian Ortlepp
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> We have been using artemis-cdi-client in its current form with javax
> libraries and would like to keep doing so once we have migrated to jakarta.
> Therefore we need a jakarta version of artemis-cdi-client.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
