[ 
https://issues.apache.org/jira/browse/ARTEMIS-5283?focusedWorklogId=955236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955236
 ]

ASF GitHub Bot logged work on ARTEMIS-5283:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Feb/25 14:40
            Start Date: 03/Feb/25 14:40
    Worklog Time Spent: 10m 
      Work Description: jbertram commented on code in PR #5485:
URL: https://github.com/apache/activemq-artemis/pull/5485#discussion_r1939493762


##########
artemis-cli/src/test/java/org/apache/activemq/artemis/cli/commands/messages/ConnectionAbstractTest.java:
##########
@@ -63,7 +64,7 @@ public void testDefaultSourceAcceptorNoArtemis() {
             connectionAbstract.execute(new TestActionContext());
          } catch (Exception e) {
             e.printStackTrace();
-            assertEquals(JMSException.class, e.getClass());
+            assertSame(JMSException.class, e.getClass());

Review Comment:
   That's fair.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 955236)
    Time Spent: 40m  (was: 0.5h)

> Tune up JUnit tests
> -------------------
>
>                 Key: ARTEMIS-5283
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5283
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are a number of categorical improvements & fixes that can be made to 
> the JUnit tests throughout the code-base. This Jira will function as a parent 
> to all the sub-tasks for this endeavor.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to