[
https://issues.apache.org/jira/browse/ARTEMIS-5139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17923836#comment-17923836
]
ASF subversion and git services commented on ARTEMIS-5139:
----------------------------------------------------------
Commit d029fd463f1f11be2ef8458050fcabf3a353e935 in activemq-artemis's branch
refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=d029fd463f ]
ARTEMIS-5139 improve locking on TypedProperties
Back in 8e40b2d4f4f242271d3dfcda4f9b96d3f94cee1b thread safety was added
to TypedProperties by synchronizing all relevant methods. This was
simple and effective but suffers from performance issues in read-heavy
use-cases.
This commit improves the performance by using a read/write locking
mechanism so reads can execute concurrently.
No new tests were added since the original commit added tests to verify
thread safety.
> Improve locking on TypedProperties
> ----------------------------------
>
> Key: ARTEMIS-5139
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5139
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Josh Byster
> Assignee: Justin Bertram
> Priority: Minor
> Labels: pull-request-available
> Attachments: Screenshot 2024-10-30 at 10.38.54 PM.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We are noticing a performance degradation when switching to Artemis in places
> where we are sensitive on the millisecond level. We have confirmed that
> moving to ZGC and having minimal GC pause times cannot explain this spike.
> Looking at a flight recording, it does appear we are spending a lot of time
> blocked on TypedProperties getters (see screenshot). It seems like we can
> probably remove some of the locking here with a concurrent collection or be
> smarter about it with a ReadWriteLock, given that it appears we have threads
> competing for read calls.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
