[
https://issues.apache.org/jira/browse/ARTEMIS-5305?focusedWorklogId=956722&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-956722
]
ASF GitHub Bot logged work on ARTEMIS-5305:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/25 14:49
Start Date: 12/Feb/25 14:49
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5498:
URL: https://github.com/apache/activemq-artemis/pull/5498#discussion_r1952804606
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/cursor/impl/PageCursorProviderImpl.java:
##########
@@ -275,7 +275,7 @@ protected void cleanup() {
try (ArtemisCloseable readLock = storageManager.closeableReadLock()) {
while (true) {
- if (pagingStore.lock(100)) {
+ if (pagingStore.writeLock(1_000)) {
Review Comment:
I did yet... writeLock will now log.debug (or trace. .don't remember now) in
case the lock is not achieved...
throwing the log.trace every 100 milliseconds was too much to follow in the
logs up to the point debug was more difficult.
This is an infinite loop anyway.
Issue Time Tracking
-------------------
Worklog Id: (was: 956722)
Time Spent: 0.5h (was: 20m)
> Improve performance on paging for multiple producers and optimize locking
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-5305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5305
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.39.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.40.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
