[
https://issues.apache.org/jira/browse/ARTEMIS-5305?focusedWorklogId=957616&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957616
]
ASF GitHub Bot logged work on ARTEMIS-5305:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 18/Feb/25 18:59
Start Date: 18/Feb/25 18:59
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5498:
URL: https://github.com/apache/activemq-artemis/pull/5498#discussion_r1960371451
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -85,7 +86,8 @@ public class PagingStoreImpl implements PagingStore {
private final PageCache usedPages = new PageCache(this);
- //it's being guarded by lock.writeLock().lock() and never read concurrently
+ // This is updated and read by the PageTimedWriter's executor thread
+ // or by a writeLock if the timedWriter is null
Review Comment:
1 is reload, which does not count (broker is not started yet)
2 directWritePage is called within the page executor
3 openNewPage is called within the page executor as well
2 and 3 will use a writeLock if the timedWriter == null
Issue Time Tracking
-------------------
Worklog Id: (was: 957616)
Time Spent: 2h 40m (was: 2.5h)
> Improve performance on paging for multiple producers and optimize locking
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-5305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5305
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.39.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.40.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
