[
https://issues.apache.org/jira/browse/ARTEMIS-5305?focusedWorklogId=958571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-958571
]
ASF GitHub Bot logged work on ARTEMIS-5305:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/25 20:03
Start Date: 24/Feb/25 20:03
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #5498:
URL: https://github.com/apache/activemq-artemis/pull/5498#discussion_r1968344317
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/paging/impl/PagingStoreImpl.java:
##########
@@ -731,17 +800,21 @@ private void resetCurrentPage(Page newCurrentPage) {
@Override
public void stopPaging() {
logger.debug("stopPaging being called, while isPaging={} on {}",
this.paging, this.storeName);
- lock.writeLock().lock();
+ writeLock();
try {
final boolean isPaging = this.paging;
if (isPaging) {
+ if (timedWriter.hasPendingIO()) {
+ logger.debug("There are pending timed writes. Cannot clear
paging now.");
Review Comment:
This condition should not happen.. we should not call stopPaging if there
are pending IO.
As a matter of fact I found one possible caller where this could happen from
clearCompleteMiddleStream, and I'm also checking in there.
I will add an assert clause in there as well, at least we would capture it
during the testsuite.
Issue Time Tracking
-------------------
Worklog Id: (was: 958571)
Time Spent: 5h 50m (was: 5h 40m)
> Improve performance on paging for multiple producers and optimize locking
> -------------------------------------------------------------------------
>
> Key: ARTEMIS-5305
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5305
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 2.39.0
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.40.0
>
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
