[ 
https://issues.apache.org/jira/browse/ARTEMIS-5349?focusedWorklogId=961734&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-961734
 ]

ASF GitHub Bot logged work on ARTEMIS-5349:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Mar/25 08:07
            Start Date: 14/Mar/25 08:07
    Worklog Time Spent: 10m 
      Work Description: AntonRoskvist commented on code in PR #5557:
URL: https://github.com/apache/activemq-artemis/pull/5557#discussion_r1995062569


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/persistence/config/PersistedBridgeConfiguration.java:
##########
@@ -62,7 +62,7 @@ public void decode(ActiveMQBuffer buffer) {
    }
 
    public String getName() {
-      return bridgeConfiguration.getParentName();
+      return bridgeConfiguration.getName();

Review Comment:
   @clebertsuconic It's not strictly necessary, but without it each 
configuration reload will log WARN messages (AMQ222124).
   
   I'll go ahead and change it so that the 
`ActiveMQServerImpl#recoverStoredBridges()` fetches this value from the 
underlying bridgeConfig instead and leave the `PersistedBridgeConfiguration` as 
it was.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 961734)
    Time Spent: 1h 10m  (was: 1h)

> Bridges with concurrency can leak
> ---------------------------------
>
>                 Key: ARTEMIS-5349
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5349
>             Project: ActiveMQ Artemis
>          Issue Type: Bug
>            Reporter: Anton Roskvist
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This affects bridges whose configuration has been persisted. Simply adding 
> persistence to the pre-existing test case captures this bug



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to