[ 
https://issues.apache.org/jira/browse/ARTEMIS-5351?focusedWorklogId=962908&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-962908
 ]

ASF GitHub Bot logged work on ARTEMIS-5351:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Mar/25 15:59
            Start Date: 21/Mar/25 15:59
    Worklog Time Spent: 10m 
      Work Description: brusdev commented on code in PR #5571:
URL: https://github.com/apache/activemq-artemis/pull/5571#discussion_r2006878882


##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/AddressControl.java:
##########
@@ -29,14 +29,14 @@ public interface AddressControl {
    String NUMBER_OF_PAGES_DESCRIPTION = "number of pages used by this address";
    String LIMIT_PERCENT_DESCRIPTION = "the % of memory limit (global or local) 
that is in use by this address";
 
-   /**
-    * {@return the managed address}
-    */
+   @Attribute(desc = "address internal ID")
+   long getId();

Review Comment:
   getId is missing the return java doc tag





Issue Time Tracking
-------------------

    Worklog Id:     (was: 962908)
    Time Spent: 40m  (was: 0.5h)

> Harmonize AddressControl and AddressView
> ----------------------------------------
>
>                 Key: ARTEMIS-5351
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5351
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> There are a number of attributes available via the {{AddressControl}} that 
> are not available on {{AddressView}}. These two classes should be harmonized 
> so that, e.g. the web console's "Addresses" tab can have the same details as 
> the JMX MBean view.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to